Make quietness of :check goal parameterized #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to introduce parameter to configure if
:check
shall be quiet (now it is).New parameter defaults to
true
, so if not set explicitly old behaviour is observed.It would allow to reduce build work, for example in client glassfish-build-maven-plugin:pom.xml#L176-L188: two goals are executed:
where
:copyright
reports violations (but does not fail the build), while:check
does not report violations but fails the build in case there is any. The work of:check
and:copyright
is almost the same and done twice is such case.glassfish-copyright-plugin/src/main/java/org/glassfish/copyright/CheckCopyrightMojo.java
Lines 29 to 42 in 94c7ba4
glassfish-copyright-plugin/src/main/java/org/glassfish/copyright/CopyrightMojo.java
Lines 29 to 36 in 94c7ba4