Add an SSH Factory parameter resolver for unsupported SCM providers #567
Conversation
vinokurig
requested review from
l0rd,
ibuziuk,
nickboldt and
tolusha
as code owners
...src/main/java/org/eclipse/che/api/factory/server/github/GithubFactoryParametersResolver.java
Show resolved
Hide resolved
...rc/main/java/org/eclipse/che/api/factory/server/git/ssh/GitSshFactoryParametersResolver.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/che/api/factory/server/github/GithubFactoryParametersResolver.java
Show resolved
Hide resolved
vinokurig
changed the title
|
/retest |
|
| @@ -183,6 +190,7 @@ protected void configure() { | |||
| scmFileResolverResolverMultibinder.addBinding().to(GitlabScmFileResolver.class); | |||
| scmFileResolverResolverMultibinder.addBinding().to(BitbucketServerScmFileResolver.class); | |||
| scmFileResolverResolverMultibinder.addBinding().to(AzureDevOpsScmFileResolver.class); | |||
| scmFileResolverResolverMultibinder.addBinding().to(GitSshScmFileResolver.class); | |||
There was a problem hiding this comment.
Should we add RawDevfileUrlFactoryParameterResolver here?
There was a problem hiding this comment.
RawDevfileUrlFactoryParameterResolver does not implement ScmFileResolver
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vinokurig: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Build 3.10 :: server_3.x/240: Console, Changes, Git Data |
|
Build 3.10 :: server_3.x/241: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.x/4726: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.x/4727: Console, Changes, Git Data |
|
Build 3.10 :: push-latest-container-to-quay_3.x/3341: Console, Changes, Git Data |
|
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4522: server : 3.x :: Failed in 55700441 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4521: server : 3.x :: Build 55700345 : quay.io/devspaces/server-rhel8:3.10-11 |
|
Build 3.10 :: update-digests_3.x/4388: Console, Changes, Git Data |
|
Build 3.10 :: server_3.x/241: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4726 triggered |
|
Build 3.10 :: operator-bundle_3.x/2080: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.x/4729: Console, Changes, Git Data |
|
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4525: devspaces-operator-bundle : 3.x :: Failed in 55703502 : BREW:BUILD/STATUS:UNKNOWN |
|
Build 3.10 :: server_3.x/242: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.x/4760: Console, Changes, Git Data |
|
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4555: server : 3.x :: Failed in 55722954 : BREW:BUILD/STATUS:UNKNOWN |
…567) Return the SSH factory resolver in order to handle SSH urls from unsupported SCM providers. Add a priority value for all factory resolvers to be able to control resolver's priority. --------- Co-authored-by: Aleksandr Shmaraiev <[email protected]>
…567) Return the SSH factory resolver in order to handle SSH urls from unsupported SCM providers. Add a priority value for all factory resolvers to be able to control resolver's priority. --------- Co-authored-by: Aleksandr Shmaraiev <[email protected]>
What does this PR do?
priorityvalue for all factory resolvers to be able to control resolver's priority.Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#22488
How to test this PR?
quay.io/eclipse/che-server:pr-567See: workspace starts from the default devfile.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.