Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Update NoSetupRepoFactory typescript test(for private repo) to work correctly with Azure DevOps #22441

Closed
SkorikSergey opened this issue Aug 17, 2023 · 2 comments
Closed

[Test] Update NoSetupRepoFactory typescript test(for private repo) to work correctly with Azure DevOps #22441

SkorikSergey opened this issue Aug 17, 2023 · 2 comments
Assignees
@artaleks9
Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@SkorikSergey
Copy link
Contributor

SkorikSergey commented Aug 17, 2023 •
edited by dmytro-ndp
Loading

Is your task related to a problem? Please describe

NoSetupRepoFactory typescript test expects Unsupported OAuth provider or No PersonalAccessTokenFetcher configured alerts when tries to start workspace for private repo without OAuth configured. But with using repo from Azure DevOps message is different(see screnshoot).

Describe the solution you'd like

We need NoSetupRepoFactory test to update test for waiting correct message.

Describe alternatives you've considered

No response

Additional context

Jenskins build - 11132

Related downstream issue: https://issues.redhat.com/browse/CRW-4534

Screenshots:

screenshot-Check_that_workspace_cannot_be_created_without_OAuth_for_private_repo (2)
@SkorikSergey SkorikSergey added kind/task Internal things, technical debt, and to-do tasks to be performed. area/qe labels Aug 17, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 17, 2023
@SkorikSergey SkorikSergey added the team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. label Aug 17, 2023
@nallikaea
Copy link
Contributor

Hello
Thank you for the issue, @SkorikSergey

Looks like a bug. Should our error messages be unified for all git providers to give our users clear feedback? @l0rd @ibuziuk @dmytro-ndp
In my opinion, it should.
Please, take a look to our regression test case:
Steps:

  1. Login into DevSpaces
  2. Try to create factory from private repo without any setups like a token or oauth

Exp: Message like "Cannot fetch the repo. Please set up PAT or OAuth Login page for ... git provider"

Act:

  • github.com: Error occurred during creation a workspace from devfile located at https://github.com... . Cause: Unsupported OAuth provider github: ...
  • GitLab.com: Error occurred during creation a workspace from devfile located at https://gitlab.com... . Cause: No PersonalAccessTokenFetcher configured for https://gitlab.com: ...
  • Azure DevOps: Failed to fetch devfile

@dkwon17 dkwon17 removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 22, 2023
@nallikaea nallikaea mentioned this issue Sep 4, 2023
Closed
@artaleks9
Copy link
Contributor

artaleks9 commented Sep 25, 2023 •
edited
Loading

@nallikaea @dmytro-ndp @SkorikSergey

According to the merged PR, for private repo without any PAT/OAuth setup, the prefix message is changed, it is now:

Cause: Could not reach devfile at

So, we need to plan an updating of this in the factory tests

  • This message was verified for github.com/GitLab.com/Bitbucket.org private repos
  • Haven't verified yet on private repos from gitlab/bitbucket servers..I assume should be the same
  • For Azure git-provider there is opened issue, investigating

@nallikaea nallikaea mentioned this issue Sep 27, 2023
Closed
@dmytro-ndp dmytro-ndp assigned artaleks9 and unassigned nallikaea Oct 30, 2023
@dmytro-ndp dmytro-ndp added severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che and removed team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. labels Oct 30, 2023
@artaleks9 artaleks9 moved this to 📅 Planned in Eclipse Che Team A Backlog Nov 29, 2023
@artaleks9 artaleks9 added the status/in-progress This issue has been taken by an engineer and is under active development. label Nov 30, 2023
@artaleks9 artaleks9 mentioned this issue Nov 30, 2023
Merged
9 tasks
@artaleks9 artaleks9 moved this from 📅 Planned to 🚧 In Progress in Eclipse Che Team A Backlog Dec 4, 2023
@artaleks9 artaleks9 removed the status/in-progress This issue has been taken by an engineer and is under active development. label Dec 5, 2023
@artaleks9 artaleks9 moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team A Backlog Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artaleks9 artaleks9

Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dmytro-ndp @artaleks9 @SkorikSergey @che-bot @nallikaea @dkwon17