-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to adapter 1.0.1 (web extension support and other improvements) #120
Conversation
This is a draft because it is depending on a "next" tagged cdt-gdb-adapter. Once we are convinced that we haven't regressed the adapter with the refactoring we can publish a "latest" tagged version and update/merge this PR. |
Hey @jonahgraham, what's the estimate for getting this change published? We were hoping to get the changes from eclipse-cdt-cloud/cdt-gdb-adapter#295 in by the end of the year. I did some testing on our IDE with the main branch of the adapter, and it works fine (obviously not definitive). If there's anything I can do to help let me know. Alternatively I could make the same changes to target a 0.x.x release in the adapter. |
@Luke-zhang-mchp I think we are probably good to progress this one too, between you and Renesas using it we are probably ok with the big refactor mentioned in the OP. |
The HEAD commit of the gdb adapter needs to be published as "latest" and then we can progress. I'll do that in the coming days. |
Hey @jonahgraham sorry to bother you, but any update on this? |
I was out sick last week - catching up now, but hopefully normal service will resume soon. Sorry for the delay. |
Oh yeah no problem, take it easy. |
eclipse-cdt-cloud/cdt-gdb-adapter#341 seems very close to ready, so I am going to give it a day or so to see if we can land it and bring that update across at the same time so I don't have to do the whole process again just a few days later. |
I'm working on this now. |
075fcc7
to
0440456
Compare
Includes: - Refactor code to allow web extension - eclipse-cdt-cloud/cdt-gdb-adapter#328 - Improved handling of ContinuedEvent - eclipse-cdt-cloud/cdt-gdb-adapter#335 - Ensure 'interrupt' and 'disconnect' signals are sent before '-gdb-exit' - eclipse-cdt-cloud/cdt-gdb-adapter#338 - Add API to pause target and wait for debugger to be suspended - eclipse-cdt-cloud/cdt-gdb-adapter#339
ba078e7
to
2a689ee
Compare
I updated the description to reflect what is included now as follows: Update to adapter 1.0.1 (web extension support and other improvements) Includes:
|
v1.0.1 of the adapter and the extension (#122) is now committed. This change didn't include the disassembly fix, so that means we will likely have v1.0.2 in the near future. |
Thanks @Luke-zhang-mchp for the contributions |
Great! And thank you for all the open source work @jonahgraham. |
Includes: