Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to adapter 1.0.1 (web extension support and other improvements) #120

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jonahgraham
Copy link
Contributor

@jonahgraham jonahgraham commented Sep 11, 2024

Includes:

@jonahgraham
Copy link
Contributor Author

This is a draft because it is depending on a "next" tagged cdt-gdb-adapter. Once we are convinced that we haven't regressed the adapter with the refactoring we can publish a "latest" tagged version and update/merge this PR.

@Luke-zhang-mchp
Copy link

Hey @jonahgraham, what's the estimate for getting this change published? We were hoping to get the changes from eclipse-cdt-cloud/cdt-gdb-adapter#295 in by the end of the year. I did some testing on our IDE with the main branch of the adapter, and it works fine (obviously not definitive).

If there's anything I can do to help let me know. Alternatively I could make the same changes to target a 0.x.x release in the adapter.

@jonahgraham
Copy link
Contributor Author

@Luke-zhang-mchp I think we are probably good to progress this one too, between you and Renesas using it we are probably ok with the big refactor mentioned in the OP.

@jonahgraham
Copy link
Contributor Author

The HEAD commit of the gdb adapter needs to be published as "latest" and then we can progress. I'll do that in the coming days.

@Luke-zhang-mchp
Copy link

Hey @jonahgraham sorry to bother you, but any update on this?

@jonahgraham
Copy link
Contributor Author

I was out sick last week - catching up now, but hopefully normal service will resume soon. Sorry for the delay.

@Luke-zhang-mchp
Copy link

Oh yeah no problem, take it easy.

@jonahgraham
Copy link
Contributor Author

eclipse-cdt-cloud/cdt-gdb-adapter#341 seems very close to ready, so I am going to give it a day or so to see if we can land it and bring that update across at the same time so I don't have to do the whole process again just a few days later.

@jonahgraham
Copy link
Contributor Author

I'm working on this now.

Includes:

- Refactor code to allow web extension
  - eclipse-cdt-cloud/cdt-gdb-adapter#328
- Improved handling of ContinuedEvent
  - eclipse-cdt-cloud/cdt-gdb-adapter#335
- Ensure 'interrupt' and 'disconnect' signals are sent before '-gdb-exit'
  - eclipse-cdt-cloud/cdt-gdb-adapter#338
- Add API to pause target and wait for debugger to be suspended
  - eclipse-cdt-cloud/cdt-gdb-adapter#339
@jonahgraham jonahgraham force-pushed the webextension branch 2 times, most recently from ba078e7 to 2a689ee Compare December 4, 2024 16:19
@jonahgraham jonahgraham changed the title Update to adapter 1.0.1-next (web extension support) Update to adapter 1.0.1 (web extension support and other improvements) Dec 4, 2024
@jonahgraham
Copy link
Contributor Author

I updated the description to reflect what is included now as follows:

Update to adapter 1.0.1 (web extension support and other improvements)

Includes:

@jonahgraham jonahgraham marked this pull request as ready for review December 4, 2024 16:20
@jonahgraham jonahgraham merged commit 2a689ee into eclipse-cdt-cloud:main Dec 4, 2024
1 check passed
@jonahgraham jonahgraham deleted the webextension branch December 4, 2024 16:22
@jonahgraham
Copy link
Contributor Author

v1.0.1 of the adapter and the extension (#122) is now committed.

This change didn't include the disassembly fix, so that means we will likely have v1.0.2 in the near future.

@jonahgraham
Copy link
Contributor Author

Thanks @Luke-zhang-mchp for the contributions

@Luke-zhang-mchp
Copy link

Great! And thank you for all the open source work @jonahgraham.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants