Refactor code to allow web extension #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jonahgraham
changed the title
jonahgraham
force-pushed
the
optimise-for-web
branch
from
f4b97e5 to
ec2acaf
Compare
This commit restructures the code base to allow alternate launch methods for the gdb/gdbserver executables by implementing new interface IGDBBackendFactory and providing an alternate implementation. The major version number is bumped to indicate to API consumers that their may be significant API changes. While there are large API changes, there is no functionality change for the desktop flow, which continues to use node's child_process package to spawn subprocesses.
jonahgraham
force-pushed
the
optimise-for-web
branch
from
ec2acaf to
812e0d3
Compare
jonahgraham
added a commit
to jonahgraham/cdt-gdb-vscode
that referenced
this pull request
Sep 11, 2024
Includes: - Refactor code to allow web extension - eclipse-cdt-cloud/cdt-gdb-adapter#328
|
@asimgunes this has been merged and published as "next" tag to npm. There is a draft PR in the extension: |
jonahgraham
added a commit
to jonahgraham/cdt-gdb-vscode
that referenced
this pull request
Dec 4, 2024
Includes: - Refactor code to allow web extension - eclipse-cdt-cloud/cdt-gdb-adapter#328 - Improved handling of ContinuedEvent - eclipse-cdt-cloud/cdt-gdb-adapter#335 - Ensure 'interrupt' and 'disconnect' signals are sent before '-gdb-exit' - eclipse-cdt-cloud/cdt-gdb-adapter#338 - Add API to pause target and wait for debugger to be suspended - eclipse-cdt-cloud/cdt-gdb-adapter#339
jonahgraham
added a commit
to jonahgraham/cdt-gdb-vscode
that referenced
this pull request
Dec 4, 2024
Includes: - Refactor code to allow web extension - eclipse-cdt-cloud/cdt-gdb-adapter#328 - Improved handling of ContinuedEvent - eclipse-cdt-cloud/cdt-gdb-adapter#335 - Ensure 'interrupt' and 'disconnect' signals are sent before '-gdb-exit' - eclipse-cdt-cloud/cdt-gdb-adapter#338 - Add API to pause target and wait for debugger to be suspended - eclipse-cdt-cloud/cdt-gdb-adapter#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restructures the code base to allow alternate launch methods
for the gdb/gdbserver executables by implementing new interface
IGDBBackendFactory and providing an alternate implementation.
The major version number is bumped to indicate to API consumers that their
may be significant API changes. While there are large API changes, there
is no functionality change for the desktop flow, which continues to use
node's child_process package to spawn subprocesses.