Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox-gh based CI #90

Merged
merged 5 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# SPDX-FileCopyrightText: 2013-2020 Christopher Kerr, "bcolsen"
# SPDX-License-Identifier: GPL-3.0-or-later

name: CI tests
on:
pull_request:
push:
branches:
- master

concurrency:
# cancels running checks on new pushes
group: check-${{ github.ref }}
cancel-in-progress: true

jobs:

pytest:
name: Run Python unit tests
# Note that 20.04 is currently required until galvani supports mdbtools>=1.0.
runs-on: ubuntu-20.04

strategy:
fail-fast: false
max-parallel: 6
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
lfs: true

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: Install MDBTools OS dependency
run: |
sudo apt install -y mdbtools

# tox-gh workflow following instructions at https://github.com/tox-dev/tox-gh
- name: Install tox
run: python -m pip install tox-gh

- name: Setup tests
run: |
tox -vv --notest

- name: Run all tests
run: |
tox --skip-pkg-install
4 changes: 2 additions & 2 deletions galvani/BioLogic.py
Original file line number Diff line number Diff line change
Expand Up @@ -426,11 +426,11 @@ def __init__(self, file_or_path):
raise ValueError("Unrecognised version for data module: %d" %
data_module['version'])

assert(not any(remaining_headers))
assert not any(remaining_headers)

self.dtype, self.flags_dict = VMPdata_dtype_from_colIDs(column_types)
self.data = np.frombuffer(main_data, dtype=self.dtype)
assert(self.data.shape[0] == n_data_points)
assert self.data.shape[0] == n_data_points

# No idea what these 'column types' mean or even if they are actually
# column types at all
Expand Down
9 changes: 8 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-FileCopyrightText: 2017-2021 Christopher Kerr <[email protected]>
# SPDX-License-Identifier: GPL-3.0-or-later
[tox]
envlist = py36,py37,py38,py39
envlist = py38,py39,py310,py311
[testenv]
deps =
flake8
Expand All @@ -15,3 +15,10 @@ commands =
[flake8]
exclude = build,dist,*.egg-info,.cache,.git,.tox,__pycache__
max-line-length = 100

[gh]
python =
3.11 = py311
3.10 = py310
3.9 = py39
3.8 = py38