Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox-gh based CI #90

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented Aug 18, 2023

As mentioned in #89, this PR adds a GitHub Actions CI workflow, based on tox-gh, to run all tests and linters for every commit and PR to master. You can see the CI running successfully on my fork at ml-evs#1, but this will need a maintainer to approve my workflow for first run (I think only @chatcannon?) Take it or leave it!

Caveats:

  • Supporting now-deprecated version of Python <=3.7 would be a bit more work in the CI, so for now I have just disabled them in the tox config. The package will still be installable with 3.6, but remains in the untested state (at least automated testing) it is now.
  • Public GitHub repos have unlimited minutes (for now...) but not unlimited git-lfs bandwidth. Each test run seems to need to pull 12 MB in the worst case, so with the current commit activity this is probably sustainable.

@ml-evs ml-evs force-pushed the ml-evs/add_gh_actions branch from 8697876 to a31a07a Compare August 18, 2023 09:22
@chatcannon chatcannon merged commit b580ee2 into echemdata:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants