-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up a minimal build environment when using system compiler #3399
set up a minimal build environment when using system compiler #3399
Conversation
check system compilers to set minimal buildenv
…en gcc/g++ is not found, add logging
2567d0f
to
d464241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Positive test with
|
Positive test with
|
Positive test with
|
(just for the record: also tested with easybuilders/easybuild-easyconfigs#11122, which is a bit of a special case) |
…or system toolchain
…ment that should be set up for system compiler, set $CC=gcc and $CXX=g++ by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy now :)
It should be safe to define
$CC
& co to the standard GCC compiler commands when using thesystem
toolchain.Not only will this fix the problem discussed in #3398, it also ensures that values for
$CC
& co that were defined outside of EasyBuild don't mess things up...(fixes #3398)