check system compilers to set minimal buildenv #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
reviewed
Aug 8, 2020
| env_vars = {} | ||
| for compiler, flags in known_sys_compilers.items(): | ||
| # distutils.spawn.find_executable() only returns first hit from $PATH | ||
| if find_executable(compiler): |
There was a problem hiding this comment.
Why not use the which function we have (in the filetools) module?
It think it also makes sense to add some logging here, to print the path to the command that was found for example.
If we don't set the variable for gfortran (I don't think it makes sense), then we can also print a warning when gcc or g++ is not found?
I'll make this changes myself in my PR easybuilders#3399
There was a problem hiding this comment.
I had no idea that EB already had a which function 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a check for the presence of the compilers in the system. Is it ok to import
distutils?find_executable()is nice because it automatically return the first hit from$PATH, which means that it will pick executables from EB before those in the system. This is useful for easyconfigs likefoss, which use theSYSTEMtoolchain but load GCC as dependencies.