Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lang}[gfbf/2023a] R v4.3.1 #18221

Merged
merged 8 commits into from
Dec 9, 2023

Conversation

verdurin
Copy link
Member

(created using eb --new-pr)

@verdurin
Copy link
Member Author

@boegelbot please test @ generoso
EB_ARGS="--skip"

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=18221 EB_ARGS="--skip" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18221 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11163

Test results coming soon (I hope)...

- notification for comment with ID 1612741931 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/abf8a1ab4df535af074e3436ee3df68d for a full test report.

@verdurin
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=18221 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18221 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11165

Test results coming soon (I hope)...

- notification for comment with ID 1612813073 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f6ddf1da85d64fdcc84d56ee157aaefb for a full test report.

@verdurin
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=18221 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18221 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11167

Test results coming soon (I hope)...

- notification for comment with ID 1613023203 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a66244576451e64be1c9451e389c384d for a full test report.

@verdurin verdurin closed this Jun 29, 2023
@verdurin verdurin reopened this Jun 29, 2023
@verdurin
Copy link
Member Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18221 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18221 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2919

Test results coming soon (I hope)...

- notification for comment with ID 1613303631 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/0015f625f707319d990dc5a53de8e8f0 for a full test report.

@fizwit
Copy link
Contributor

fizwit commented Jun 29, 2023

Would consider adding ggplot2? ggplot2 is a dependency 67 times in R-4.3.0.

@verdurin
Copy link
Member Author

verdurin commented Jul 3, 2023

Would consider adding ggplot2? ggplot2 is a dependency 67 times in R-4.3.0.

What does it require?

@fizwit
Copy link
Contributor

fizwit commented Jul 4, 2023

hmmm, ggplot2 requires 14 dependencies that are not in the current R-4.3.1. I have put ggplot2 into a new easyconfig R-Tidyverse-4.3.1 which is larger than the base R. Started with eight libraries with R-Tidyverse and processed with easy_update. The result is about 130 libraries.

@verdurin
Copy link
Member Author

verdurin commented Jul 5, 2023 via email

@boegel boegel added this to the release after 4.7.3 milestone Jul 6, 2023
@verdurin
Copy link
Member Author

hmmm, ggplot2 requires 14 dependencies that are not in the current R-4.3.1. I have put ggplot2 into a new easyconfig R-Tidyverse-4.3.1 which is larger than the base R. Started with eight libraries with R-Tidyverse and processed with easy_update. The result is about 130 libraries.

Thanks. Are you happy with that approach then, rather than adding ggplot2 here?

@fizwit
Copy link
Contributor

fizwit commented Jul 10, 2023

hmmm, ggplot2 requires 14 dependencies that are not in the current R-4.3.1. I have put ggplot2 into a new easyconfig R-Tidyverse-4.3.1 which is larger than the base R. Started with eight libraries with R-Tidyverse and processed with easy_update. The result is about 130 libraries.

Thanks. Are you happy with that approach then, rather than adding ggplot2 here?

Yes, This PR looks good to me. I am using this PR in production at the Hutch. ggplot2 is part of the Tidyverse.

For my local site, I am using this PR as the base and adding to it.
R-3.4.1 + R-Tidyverse + BioConductor = fhR

@verdurin verdurin changed the title {lang}[gfbf/2022b] R v4.3.1 {lang}[gfbf/2023a] R v4.3.1 Aug 11, 2023
@verdurin
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=18221 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18221 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11460

Test results coming soon (I hope)...

- notification for comment with ID 1675013933 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

@verdurin: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/5834675806
Output from first failing test suite run:

FAIL: test_style_conformance (test.easyconfigs.styletests.StyleTest)
Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/base/testing.py", line 97, in assertEqual
    super(TestCase, self).assertEqual(a, b)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/unittest/case.py", line 829, in assertEqual
    assertion_func(first, second, msg=msg)
AssertionError: 5 != 0

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 68, in test_style_conformance
    self.assertEqual(result, 0, error_msg)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/base/testing.py", line 119, in assertEqual
    raise AssertionError("%s:\nDIFF%s:\n%s" % (msg, limit, ''.join(diff[:self.ASSERT_MAX_DIFF])))
AssertionError: There shouldn't be any code style errors (and/or warnings), found 5:
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:16:5: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:38:5: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:39:5: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:40:5: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:41:5: E265 block comment should start with '# '

: 5 != 0:
DIFF:
- 5

----------------------------------------------------------------------
Ran 17777 tests in 1133.990s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel boegel modified the milestones: 4.8.1, release after 4.8.1 Sep 9, 2023
@easybuilders easybuilders deleted a comment from boegelbot Oct 23, 2023
@boegelbot
Copy link
Collaborator

@verdurin: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/6617574882
Output from first failing test suite run:

FAIL: test_style_conformance (test.easyconfigs.styletests.StyleTest)
Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/base/testing.py", line 97, in assertEqual
    super(TestCase, self).assertEqual(a, b)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/unittest/case.py", line 829, in assertEqual
    assertion_func(first, second, msg=msg)
AssertionError: 5 != 0

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 68, in test_style_conformance
    self.assertEqual(result, 0, error_msg)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/base/testing.py", line 119, in assertEqual
    raise AssertionError("%s:\nDIFF%s:\n%s" % (msg, limit, ''.join(diff[:self.ASSERT_MAX_DIFF])))
AssertionError: There shouldn't be any code style errors (and/or warnings), found 5:
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:16:5: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:38:5: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:39:5: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:40:5: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-4.3.1-gfbf-2023a.eb:41:5: E265 block comment should start with '# '

: 5 != 0:
DIFF:
- 5

----------------------------------------------------------------------
Ran 18369 tests in 1072.690s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

('libjpeg-turbo', '2.1.5.1'), # for plottting in R
('LibTIFF', '4.5.0'),
('Java', '11', '', SYSTEM),
('libgit2', '1.7.0'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A newer libgit2 was already merged in #18606

Suggested change
('libgit2', '1.7.0'),
('libgit2', '1.7.1'),

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdurin I updated to R 4.3.2, added the required dependencies and updated the extensions in verdurin#8

@lexming lexming merged commit f7cf39a into easybuilders:develop Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants