Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidenav documentation fixes #585

Merged
merged 5 commits into from
Oct 28, 2021
Merged

Sidenav documentation fixes #585

merged 5 commits into from
Oct 28, 2021

Conversation

aweell
Copy link
Collaborator

@aweell aweell commented Oct 19, 2021 •
edited
Loading

Changes

  • subtitleFontColor and linkFontColor updated to color-grey-800 (#4d4d4d)
  • Update spacing specifications
  • Update documentation structure

This was referenced Oct 19, 2021
Closed
Open
@aweell
Copy link
Collaborator Author

aweell commented Oct 19, 2021 •
edited
Loading

Suggestions

  • Add tokens for :hover, :focus and :active states of the Sidenav Link children component

Screen Shot 2021-10-19 at 3 07 43 PM

Current :focus link state

Proposed states:

Screen Shot 2021-10-19 at 3 45 13 PM

This change also affects the structure of the <li> and <ul> elements.

@aweell aweell linked an issue Oct 20, 2021 that may be closed by this pull request
[Sidenav] Update documentation to the new template #579
Closed
@aweell aweell merged commit dba6ca7 into 3.11.0 Oct 28, 2021
@aweell aweell deleted the component-sidenav branch October 28, 2021 06:59
@aweell aweell mentioned this pull request Oct 28, 2021
Closed
@aweell aweell linked an issue Nov 15, 2021 that may be closed by this pull request
[Sidenav] Color specs update #303
Closed
5 tasks
@aweell aweell mentioned this pull request Nov 15, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sidenav] Update documentation to the new template [Sidenav] Color specs update
1 participant
@aweell