Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sidenav] Component specs #399

Closed
3 tasks done
aweell opened this issue Oct 19, 2021 · 1 comment · Fixed by #415
Closed
3 tasks done

[Sidenav] Component specs #399

aweell opened this issue Oct 19, 2021 · 1 comment · Fixed by #415
Assignees
@GomezIvann

Comments

@aweell
Copy link
Collaborator

aweell commented Oct 19, 2021 •
edited
Loading

Latest component documentation

Changes

  • subtitleFontColor and linkFontColor updated to color-grey-800 (#4d4d4d)
  • Updated spacing properties
  • Update focus.

There's a PR open for 3.11.0 , any change or fix can be suggested there.
@GomezIvann GomezIvann self-assigned this Oct 22, 2021
GomezIvann added a commit that referenced this issue Oct 28, 2021
@GomezIvann
[Patch] Fix #399 Sidenav component specs update
d1e7ca2
@GomezIvann GomezIvann linked a pull request Oct 28, 2021 that will close this issue
[Patch] Fix #399 Sidenav specs update #415
Merged
@GomezIvann
Copy link
Collaborator

New specs for the Sidenav's links focus included:

  • linkFocusColor token added with color value #0095ff.
  • outline: 2px solid #0095ff;.
  • outline-offset: 1px;.

GomezIvann added a commit that referenced this issue Nov 8, 2021
@GomezIvann
Merge pull request #415 from dxc-technology/gomezivann-sidenav-fix
631f025 
[Patch] Fix #399 Sidenav specs update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GomezIvann GomezIvann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Patch] Fix #399 Sidenav specs update dxc-technology/halstack-react
2 participants
@GomezIvann @aweell