Like/Unlike Implementation #43, Minimize to Tray #86 and Fix for Native Title Bar #83 #88
Conversation
…rint width (mine is at 120)
The workspace settings doesn't work, nor is .prettierrc.json... :|
- Added `show in taskbar` setting - Apply new settings without reloading - Only reset user-modifiable settings when resetting to factory defaults (i.e. do not remove the auth tokens) - Fixed white background when closing the debug console
This hides the min/max buttons when disabled
Focusable will always be true This causes bug #87
Position the window in the middle of the screen on 1st time launch or when 'remember window position' is false
stamoun
changed the title
|
This is great! had time to look at it, and the only problem I'm seeing is that I sometimes have to re-auth again after I launch Lofi. For some reason, it's not properly remembering the past authorization token. I need to look at the code because I know the auth flow changed a bit, so I'll be able to get to the bottom of it. There's also a bit of an inconsistency with the control padding (more space left-to-right than top-to-bottom), but that's just a CSS tweak. Awesome job as always! I love the alert icon at the bottom when requests are throttled, but I'm not sure if we should disable the controls visually -- I only say this because I was actually confused a few times when controls would randomly get greyed out (due to random Spotify throttling on the heartbeat requests). |
I noticed that too, but it was somewhat rare. I think it occurs when an error (503?) happens in the backend while fetching/refreshing the access token. Nothing much we can do about it (once the refresh token is spent, it can't be reused).
Yah, I hear ya, wasn't sure how to tell the user that the controls won't work since the API calls are being throttled. I'll just remove the disabled stuff and leave it as is for now. You'll decide where to take this next ;) |
|
Finally had time to circle back and look at this. I was able to solve the re-auth problem by also adding Thanks again for all your hard work @stamoun! |
This is the implementation of enhancements #43 and fixes for issues #80 and #83
The only caveat is that we now make 2 requests in
listeningTo, one to fillcurrently_playingthe other to determine if the track is liked or not. This good lead to more429errors, but it does the same amount (or less) of API requests as version1.5.0does (I moved thekeepAlivemethod to a 5sec interval only if the player is paused.Be aware that this PR exposes issue #87 more on Linux (workaround: use alt/super key to drag the window past the boundary).
Prior to this version bug issue #87 only happened when the user had
always on topunchecked.