Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2: Change name of 'value' field on coupons #642

Merged
merged 5 commits into from
Jun 1, 2022

Conversation

duncanmcclean
Copy link
Owner

@duncanmcclean duncanmcclean commented Jun 1, 2022

This pull request changes the name of the 'value' field on coupons. Instead of the field being value, it's now coupon_value.

This is due to Statamic having issues if you have a field with the handle, value (statamic/cms#2495).

Related: #559

To Do

  • Renamed the field
  • Updated the tests
  • Added to default blueprint (needs to be done in the starter kit too)
  • Created an upgrade script

@duncanmcclean duncanmcclean merged commit 92580c5 into 3.x Jun 1, 2022
@duncanmcclean duncanmcclean deleted the resolve-conflicts-with-coupon-value-field branch June 1, 2022 18:42
duncanmcclean added a commit to duncanmcclean/sc-starter-kit that referenced this pull request Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Released as part of v3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant