Fix issue with coupons not being augmented properly #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue` field being present Due to statamic/cms#2495
Apply fixes from StyleCI
|
Released as part of v2.3.65. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where coupons weren't aren't being augmented properly.
Basically, augmentation for coupons is currently broken as the percent/amount field is called
handle(due to statamic/cms#2495). This pull request doesn't really fix it but workaround it for now when using the coupon in Simple Commerce.In the long term, Statamic will fix the issue with fields with the handle
valueor we will change it to something likeamountwhich would need to be done as a breaking change.Fixes #558