Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require 'www' when showing full URL #539

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Don't require 'www' when showing full URL #539

merged 1 commit into from
Apr 14, 2022

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Apr 14, 2022 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1199178362774117/1202127560661448/f

Description:
Don't require 'www' when showing full URL

Steps to test this PR:

  1. enable "Show full URL" in Appearance Settings
  2. open theguardian.com, verify that it's rewritten to www.theguardian.com (server-side, expected)
  3. open app.asana.com, verify that it's not rewritten to www.app.asana.com

Testing checklist:

  • Test with Release configuration
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@ayoy ayoy force-pushed the dominik/fix-show-full-url branch from a943877 to b418fec Compare April 14, 2022 08:17
@brindy brindy self-assigned this Apr 14, 2022
brindy
brindy approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit ee1ec8a into develop Apr 14, 2022
@brindy brindy deleted the dominik/fix-show-full-url branch April 14, 2022 10:56
samsymons added a commit that referenced this pull request Apr 14, 2022
@samsymons
Merge branch 'develop' into dominik/disable-autocomplete
b1fcca3 
# By Brad Slayter (1) and Dominik Kapusta (1)
# Via GitHub
* develop:
  Don't cancel request for background tabs (#526)
  Don't require 'www' when showing full URL (#539)

# Conflicts:
#	DuckDuckGo/Browser Tab/ViewModel/TabViewModel.swift
samsymons added a commit that referenced this pull request Apr 15, 2022
@samsymons
Merge branch 'develop' into sam/password-generation
63a8153 
* develop:
  Don't cancel request for background tabs (#526)
  Don't require 'www' when showing full URL (#539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees

@brindy brindy

Labels
merge on approve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoy @brindy