Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cancel request for background tabs #526

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Don't cancel request for background tabs #526

merged 1 commit into from
Apr 14, 2022

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1199178362774117/1201433189309418/f
Tech Design URL:
CC: @GuiltyDolphin

Description:
This PR fixes an issue where trying to open a tab in the background for sites on the GPC header sites opens in the current tab instead.

Steps to test this PR:

  1. Ensure you are loading the local config only
  2. Visit nytimes.com
  3. Command+click any link that stays on nytimes.com. Page should open in the background
  4. Visit globalprivacycontrol.org
  5. Command+click "Test against the reference server." Page should open in the background and GPC signal detected.

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy self-assigned this Apr 14, 2022
brindy
brindy approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For such a small change that was a PITA to test given the need to edit BSK to only load the embedded data :)

LGTM though

@brindy brindy assigned SlayterDev and unassigned brindy Apr 14, 2022
@SlayterDev SlayterDev merged commit ebf3b25 into develop Apr 14, 2022
@SlayterDev SlayterDev deleted the brad/gpc-background-tab branch April 14, 2022 11:43
samsymons added a commit that referenced this pull request Apr 14, 2022
@samsymons
Merge branch 'develop' into dominik/disable-autocomplete
b1fcca3 
# By Brad Slayter (1) and Dominik Kapusta (1)
# Via GitHub
* develop:
  Don't cancel request for background tabs (#526)
  Don't require 'www' when showing full URL (#539)

# Conflicts:
#	DuckDuckGo/Browser Tab/ViewModel/TabViewModel.swift
samsymons added a commit that referenced this pull request Apr 15, 2022
@samsymons
Merge branch 'develop' into sam/password-generation
63a8153 
* develop:
  Don't cancel request for background tabs (#526)
  Don't require 'www' when showing full URL (#539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlayterDev @brindy