Prevent the Autofill Cancel button from resetting item selection #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brindy This is something you can probably add context to. This fixes an issue where simply canceling an editing state would reset the selected item, @ayoy noticed that it was coming from the |
|
I think it was so that the empty state for the item didn't appear when you were editing a new entry, but I just tested this PR and that looks OK. |
|
@brindy Ah, that would explain it, thanks! I did make some empty state improvements after the onboarding work, so I would guess that those have fixed the same issue, meaning we're safe to remove this. |
samsymons
added a commit
that referenced
this pull request
Apr 14, 2022
# By Dominik Kapusta (4) and others # Via GitHub * develop: ‘Rename user-facing “Preferences” strings to “Settings”. (#519) Fix URLs with port and replace spaces in query with %20 (#506) Printing custom frame (#530) Fix warnings in unit tests target (#490) Version 0.22.3 FTP scheme handled as internal (#524) Old compilation flag removed (#531) Don't use ZStack as it messes up the layout on Catalina (#532) Disable context menu for Privacy Dashboard (#512) Add unit tests Github Actions workflow (#525) Add a shell script and GitHub Action to create notarized builds (#517) Add missing period in 'Privacy, simplified.' tagline (#527) move some state into the model so that SwiftUI doesn't remember it if that object comes back (#521) Prevent the Autofill Cancel button from resetting item selection (#520) Fix animation hitching. (#518) Add description fields to breakage reporting flows (#511) Update BSK with a fix for query params (#513) set the default height of the navigation bar so that it can be used when configuring a popup window (#522) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202040507157531/f
Tech Design URL:
CC: @ayoy
Description:
This PR removes the
onCancelledblock from the Autofill data models.This block was getting called after going into an editing state and then simply cancelling, triggering the list model to reselect the first item in the list.
This block was introduced in the onboarding PR, but removing it appears to fix this issue with no negative side effects.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM