Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable context menu for Privacy Dashboard #512

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Apr 7, 2022

Task/Issue URL: https://app.asana.com/0/1199237043630360/1202041875100959
Tech Design URL:
CC:

Description:
Disables context menu in Privacy Dashboard

Steps to test this PR:

  1. Validate Context Menu is not opening in Privacy Dashboard

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@samsymons samsymons self-assigned this Apr 7, 2022
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed some animation hitching while testing that is unrelated to these changes, have written them up here.

This PR is good to go 🙂

@samsymons samsymons assigned mallexxx and unassigned samsymons Apr 9, 2022
@mallexxx mallexxx merged commit cdb0e26 into develop Apr 12, 2022
@mallexxx mallexxx deleted the alex/disable-dashboard-menu branch April 12, 2022 13:27
samsymons added a commit that referenced this pull request Apr 14, 2022
# By Dominik Kapusta (4) and others
# Via GitHub
* develop:
  ‘Rename user-facing “Preferences” strings to “Settings”. (#519)
  Fix URLs with port and replace spaces in query with %20 (#506)
  Printing custom frame (#530)
  Fix warnings in unit tests target (#490)
  Version 0.22.3
  FTP scheme handled as internal (#524)
  Old compilation flag removed (#531)
  Don't use ZStack as it messes up the layout on Catalina (#532)
  Disable context menu for Privacy Dashboard (#512)
  Add unit tests Github Actions workflow (#525)
  Add a shell script and GitHub Action to create notarized builds (#517)
  Add missing period in 'Privacy, simplified.' tagline (#527)
  move some state into the model so that SwiftUI doesn't remember it if that object comes back (#521)
  Prevent the Autofill Cancel button from resetting item selection (#520)
  Fix animation hitching. (#518)
  Add description fields to breakage reporting flows (#511)
  Update BSK with a fix for query params (#513)
  set the default height of the navigation bar so that it can be used when configuring a popup window (#522)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants