Fix reloading data in BookmarkListViewController #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Apr 10, 2022
* develop: Fill Add Bookmark modal view with current tab website (#515) Fix reloading data in BookmarkListViewController (#514) use the page url in the tracker object rather than the current web view url (#509) Version 0.22.2 Revert the change to Arc4RandomUniformVariantRNG and silence SwiftLint warning (#510) Revert the change to Arc4RandomUniformVariantRNG and silence SwiftLint warning (#510) Version 0.22.1 Improve Chromium Logins import (#501) Revert "New autoconsent rules and move tab cleanup out of onCommitted (#489)" (#502) Add fallback icons for password managers (#504) Make SwiftLint happy (#508) Default to Chrome or Safari when importing Logins and Bookmarks (#503)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201475153527864/f
CC: @samsymons
Description:
Reload
BookmarkOutlineViewDataSource(that rebuilds bookmarks tree internally)when reloading
BookmarkListViewControllercontents. The same approach is takenin
BookmarkManagementSidebarViewControllerwhere this bug is not observed.Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM