Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SwiftLint 0.47.0 warning #508

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Apr 6, 2022

Task/Issue URL: N/A

Description:
Replace arc4random_uniform with Int.random.

Steps to test this PR:

  1. Make sure tests pass

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@mallexxx mallexxx self-assigned this Apr 6, 2022
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy merged commit a6a5670 into develop Apr 6, 2022
@ayoy ayoy deleted the dominik/fix-swiftlint-warning branch April 6, 2022 09:38
@mallexxx mallexxx assigned ayoy and unassigned mallexxx Apr 6, 2022
samsymons added a commit that referenced this pull request Apr 10, 2022
* develop:
  Fill Add Bookmark modal view with current tab website (#515)
  Fix reloading data in BookmarkListViewController (#514)
  use the page url in the tracker object rather than the current web view url (#509)
  Version 0.22.2
  Revert the change to Arc4RandomUniformVariantRNG and silence SwiftLint warning (#510)
  Revert the change to Arc4RandomUniformVariantRNG and silence SwiftLint warning (#510)
  Version 0.22.1
  Improve Chromium Logins import (#501)
  Revert "New autoconsent rules and move tab cleanup out of onCommitted (#489)" (#502)
  Add fallback icons for password managers (#504)
  Make SwiftLint happy (#508)
  Default to Chrome or Safari when importing Logins and Bookmarks (#503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants