New privacy icon animation + crash dialog copy change #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairjcbrown
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Tested locally -- animations look good, crash reporting copy is correct and works as expected
LGTM 
|
Thanks a lot @alistairjcbrown! |
samsymons
added a commit
that referenced
this pull request
Oct 28, 2021
# By Alistair Brown (2) and others # Via GitHub * develop: Update tracker information on refresh to support toggling protection (#286) Pass site parent entity to Privacy Dashboard (#285) Copy updates for Friends & Family (#283) New privacy icon animation + crash dialog copy change (#284) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
samsymons
added a commit
that referenced
this pull request
Nov 4, 2021
* develop: (34 commits) Update protections to use config features where appropriate (#292) Fix newlines in gpc exceptions causing JS exceptions (#306) Increase priority of content blocker compile rules process (#293) Make eslint replacements match iOS code (#299) Update bindings to latest WebKit changes in 13.1 XCode (#271) Version 0.17.3 Avoid Fireproofing the same website multiple times (#288) Copy Changes, Part 2 (#287) Fire popover dark colors corrected (#291) Fix leaking TabCollectionViewModel (#289) Version 0.17.2 Secure Vault additions (#281) Update tracker information on refresh to support toggling protection (#286) Pass site parent entity to Privacy Dashboard (#285) Copy updates for Friends & Family (#283) New privacy icon animation + crash dialog copy change (#284) Fire button options (#280) Missing credentials API fix (#275) Disabling SafeBrowsing due to privacy implications (#278) Move the code that is removing the debug menu item. (#282) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URLs:
https://app.asana.com/0/0/1201264847158912/f
https://app.asana.com/0/1177771139624306/1200984331874224/f
Description:
New privacy icon animation files and crash dialog copy change
Steps to test this PR:
Run the app in release configuration
Crash it (Debug menu -> Fatal Error)
Wait few seconds
Run the app again to see the dialog
Make sure it contains
Click "Send to DuckDuckGo" to submit report to DuckDuckGo. Crash reports help DuckDuckGo diagnose issues and improve our products. No personal information is sent with this report.
Test the privacy icon animation in both aqua and dark mode for HTTP and HTTPS site (http://www.dsl.sk)
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM