Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing credentials API fix #275

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Missing credentials API fix #275

merged 1 commit into from
Oct 28, 2021

Conversation

jonathanKingston
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199178362774117/1201249917946402/f
Tech Design URL:
CC:

Description:

On imgur.com they're expecting the credential API to be present, probably based on UA string.

This is pending agreement on the config key and a PR to that repo but other than there is no blocker to merging.

There's more copy and paste here for the config checking, we could make part of this PR a separate file that we read in an external file, something like:

        return CredentialsUserScript.loadJS("credentials", from: .main, withReplacements: [
             "import * from 'utils';": CredentialsUserScript.loadJS("utils"),
             "USER_UNPROTECTED_DOMAINS": "",
             "CREDENTIALS_EXCEPTIONS": (unprotectedDomains + contentBlockingExceptions).joined(separator: "\n")
        ])

Steps to test this PR:

  1. load imgur.com

Expected
Site to have content

Actual
Site is blank

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@jonathanKingston
Copy link
Collaborator Author

/cc @alistairjcbrown @samsymons (seems I can't add more than one reviewer)

Copy link
Contributor

@SlayterDev SlayterDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once the config change is in.

In regards to the script imports I'm open to it if you want to do it as part of this PR but I feel that's a decision that should also have @tomasstrba's and probably @samsymons's eyes.

@jonathanKingston jonathanKingston force-pushed the jkt/credentials branch 2 times, most recently from 4c857d5 to 55ff9cd Compare October 26, 2021 21:15
@tomasstrba
Copy link
Contributor

@jonathanKingston, please, do you want to merge this today for F&F release build?

Copy link
Contributor

@SlayterDev SlayterDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved this earlier but was waiting for the Remote Config change to land.

@tomasstrba tomasstrba merged commit c8fd15a into develop Oct 28, 2021
@tomasstrba tomasstrba deleted the jkt/credentials branch October 28, 2021 14:36
samsymons added a commit that referenced this pull request Oct 28, 2021
# By Jonathan Kingston (2) and others
# Via GitHub
* develop:
  Fire button options (#280)
  Missing credentials API fix (#275)
  Disabling SafeBrowsing due to privacy implications (#278)
  Move the code that is removing the debug menu item. (#282)
  macOS Browser instrumentation for F&F Beta (#269)

# Conflicts:
#	DuckDuckGo/Common/Localizables/UserText.swift
samsymons added a commit that referenced this pull request Oct 28, 2021
# By Jonathan Kingston (2) and others
# Via GitHub
* develop:
  Fire button options (#280)
  Missing credentials API fix (#275)
  Disabling SafeBrowsing due to privacy implications (#278)
  Move the code that is removing the debug menu item. (#282)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
samsymons added a commit that referenced this pull request Nov 4, 2021
* develop: (34 commits)
  Update protections to use config features where appropriate (#292)
  Fix newlines in gpc exceptions causing JS exceptions (#306)
  Increase priority of content blocker compile rules process (#293)
  Make eslint replacements match iOS code (#299)
  Update bindings to latest WebKit changes in 13.1 XCode (#271)
  Version 0.17.3
  Avoid Fireproofing the same website multiple times (#288)
  Copy Changes, Part 2 (#287)
  Fire popover dark colors corrected (#291)
  Fix leaking TabCollectionViewModel (#289)
  Version 0.17.2
  Secure Vault additions (#281)
  Update tracker information on refresh to support toggling protection (#286)
  Pass site parent entity to Privacy Dashboard (#285)
  Copy updates for Friends & Family (#283)
  New privacy icon animation + crash dialog copy change (#284)
  Fire button options (#280)
  Missing credentials API fix (#275)
  Disabling SafeBrowsing due to privacy implications (#278)
  Move the code that is removing the debug menu item. (#282)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants