-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing credentials API fix #275
Conversation
/cc @alistairjcbrown @samsymons (seems I can't add more than one reviewer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once the config change is in.
In regards to the script imports I'm open to it if you want to do it as part of this PR but I feel that's a decision that should also have @tomasstrba's and probably @samsymons's eyes.
4c857d5
to
55ff9cd
Compare
DuckDuckGo/BrowserTab/Model/NavigatorCredentialsUserScript.swift
Outdated
Show resolved
Hide resolved
55ff9cd
to
62156eb
Compare
62156eb
to
89569b4
Compare
@jonathanKingston, please, do you want to merge this today for F&F release build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved this earlier but was waiting for the Remote Config change to land.
# By Jonathan Kingston (2) and others # Via GitHub * develop: Fire button options (#280) Missing credentials API fix (#275) Disabling SafeBrowsing due to privacy implications (#278) Move the code that is removing the debug menu item. (#282) macOS Browser instrumentation for F&F Beta (#269) # Conflicts: # DuckDuckGo/Common/Localizables/UserText.swift
* develop: (34 commits) Update protections to use config features where appropriate (#292) Fix newlines in gpc exceptions causing JS exceptions (#306) Increase priority of content blocker compile rules process (#293) Make eslint replacements match iOS code (#299) Update bindings to latest WebKit changes in 13.1 XCode (#271) Version 0.17.3 Avoid Fireproofing the same website multiple times (#288) Copy Changes, Part 2 (#287) Fire popover dark colors corrected (#291) Fix leaking TabCollectionViewModel (#289) Version 0.17.2 Secure Vault additions (#281) Update tracker information on refresh to support toggling protection (#286) Pass site parent entity to Privacy Dashboard (#285) Copy updates for Friends & Family (#283) New privacy icon animation + crash dialog copy change (#284) Fire button options (#280) Missing credentials API fix (#275) Disabling SafeBrowsing due to privacy implications (#278) Move the code that is removing the debug menu item. (#282) ...
Task/Issue URL: https://app.asana.com/0/1199178362774117/1201249917946402/f
Tech Design URL:
CC:
Description:
On imgur.com they're expecting the credential API to be present, probably based on UA string.
This is pending agreement on the config key and a PR to that repo but other than there is no blocker to merging.
There's more copy and paste here for the config checking, we could make part of this PR a separate file that we read in an external file, something like:
Steps to test this PR:
Expected
Site to have content
Actual
Site is blank
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM