Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add #URL macro #2179

Merged
merged 19 commits into from
Mar 7, 2024
Merged

add #URL macro #2179

merged 19 commits into from
Mar 7, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Feb 8, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/42792087274227/1206542455948401/f
BSK PR: duckduckgo/BrowserServicesKit#657
iOS PR: duckduckgo/iOS#2540
toolbox PR: duckduckgo/apple-toolbox#2

Description:

Steps to test this PR:

  1. Validate both local and CI tests pass
  2. Validate macro expansions match origin URL(string:) constructs
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 60a32b9

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 9, 2024
@mallexxx mallexxx mentioned this pull request Feb 29, 2024
Merged
6 tasks
@mallexxx mallexxx requested a review from ayoy February 29, 2024 09:22
@mallexxx mallexxx changed the title [Test] add #URL macro add #URL macro Feb 29, 2024
@mallexxx mallexxx added includes BSK changes and removed bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project labels Feb 29, 2024
@mallexxx mallexxx mentioned this pull request Feb 29, 2024
Merged
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 29, 2024
@mallexxx mallexxx removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 29, 2024
ayoy
ayoy approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@ayoy ayoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect. I love how much cleaner it makes the code look. Thanks a lot @mallexxx!

mallexxx added a commit to duckduckgo/apple-toolbox that referenced this pull request Mar 6, 2024
@mallexxx
#URL macro (#2)
d51beaf 
Task URL: https://app.asana.com/0/42792087274227/1206542455948401/f
BSK PR: duckduckgo/BrowserServicesKit#657
macOS PR: duckduckgo/macos-browser#2179
iOS PR: duckduckgo/iOS#2540
mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Mar 7, 2024
@mallexxx
#URL macro (#657)
dbe75fa 
Task/Issue URL: https://app.asana.com/0/42792087274227/1206542455948401/f
iOS PR: duckduckgo/iOS#2540
macOS PR: duckduckgo/macos-browser#2179
apple-toolbox PR: duckduckgo/apple-toolbox#2
@mallexxx mallexxx merged commit 7504712 into main Mar 7, 2024
17 checks passed
@mallexxx mallexxx deleted the alex/url-macro branch March 7, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@mallexxx mallexxx

Labels
includes BSK changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @ayoy