#URL macro #2
Merged
#URL macro #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ayoy
reviewed
Mar 4, 2024
|
Updated the comment and opened iOS PR |
ayoy
reviewed
Mar 6, 2024
Comment on lines
21
to
35
| /// Compile-time validated OS version independent URL instantiation from String Literal. | ||
| /// | ||
| /// Used to statically validate preset URLs. | ||
| /// The idea is to disable any flaky URL conversions like punycode or no-scheme urls, only 1-1 mapped String Literals can be used. | ||
| /// | ||
| /// Usage: `let url = #URL("https://duckduckgo.com")` | ||
| /// | ||
| /// - Note: Strings like "http://💩.la" or "1" are not valid #URL parameter values. | ||
| /// To instantiate a parametrized URL use `URL.appendingPathComponent(_:)` or `URL.appendingParameters(_:allowedReservedCharacters:)` | ||
| /// To instantiate a URL from a String format, use `URL(string:)` | ||
| /// | ||
| /// - Parameter string: valid URL String Literal with URL scheme and | ||
| /// - Returns: URL instance if provided string argument is a valid URL | ||
| /// - Throws: Compile-time error if provided string argument is not a valid URL | ||
| /// |
ayoy
approved these changes
Mar 6, 2024
mallexxx
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/42792087274227/1206542455948401/f iOS PR: duckduckgo/iOS#2540 macOS PR: duckduckgo/macos-browser#2179 apple-toolbox PR: duckduckgo/apple-toolbox#2
mallexxx
added a commit
to duckduckgo/iOS
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/42792087274227/1206542455948401/f BSK PR: duckduckgo/BrowserServicesKit#657 toolbox PR: duckduckgo/apple-toolbox#2
mallexxx
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Mar 7, 2024
Task/Issue URL: https://app.asana.com/0/42792087274227/1206542455948401/f BSK PR: duckduckgo/BrowserServicesKit#657 iOS PR: duckduckgo/iOS#2540 toolbox PR: duckduckgo/apple-toolbox#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task URL: https://app.asana.com/0/42792087274227/1206542455948401/f
BSK PR: duckduckgo/BrowserServicesKit#657
macOS PR: duckduckgo/macos-browser#2179
iOS PR: duckduckgo/iOS#2540