Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle camera access request in sync recovery flow #3942

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

loremattei
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1204165176092271/1209342734692466
Tech Design URL:
CC:

Description:
This PR handles the Camera access request modal in the same way of sync_login to avoid failures like this one.

Steps to test this PR:

  1. Run Maestro sync tests and validate the pass.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@loremattei loremattei marked this pull request as ready for review February 7, 2025 08:56
@loremattei loremattei requested a review from ayoy February 7, 2025 10:47
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tested Maestro sync setup scenario with the camera and it worked fine 👍

@loremattei loremattei merged commit 59338d2 into main Feb 7, 2025
19 checks passed
@loremattei loremattei deleted the loremattei/improve-sync-recover-data-flow branch February 7, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants