Skip to content

Commit

Permalink
Handle camera access request in sync recovery flow (#3942)
Browse files Browse the repository at this point in the history
<!--
Note: This checklist is a reminder of our shared engineering
expectations. Feel free to change it, although assigning a GitHub
reviewer and the items in bold are required.

⚠️ If you're an external contributor, please file an issue first before
working on a PR, as we can't guarantee that we will accept your changes
if they haven't been discussed ahead of time. Thanks!
-->

Task/Issue URL:
https://app.asana.com/0/1204165176092271/1209342734692466
Tech Design URL:
CC:

**Description**:
This PR handles the Camera access request modal in the same way of
[sync_login](https://github.com/duckduckgo/iOS/blob/main/.maestro/shared/sync_login.yaml)
to avoid failures like [this
one](https://github.com/duckduckgo/iOS/actions/runs/13191313782/job/36824864001#step:6:32).
<!--
If at any point it isn't actively being worked on/ready for
review/otherwise moving forward strongly consider closing it (or not
opening it in the first place). If you decide not to close it, use Draft
PR while work is still in progress or use `DO NOT MERGE` label to
clarify the PRs state and comment with more information.
-->

**Steps to test this PR**:
1. Run Maestro sync tests and validate the pass. 
2.

<!--
Before submitting a PR, please ensure you have tested the combinations
you expect the reviewer to test, then delete configurations you *know*
do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
-->

**Definition of Done (Internal Only)**:

* [x] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Copy Testing**:

* [ ] Use of correct apostrophes in new copy, ie `’` rather than `'`

**Orientation Testing**:

* [ ] Portrait
* [ ] Landscape

**Device Testing**:

* [ ] iPhone SE (1st Gen)
* [ ] iPhone 8
* [ ] iPhone X
* [ ] iPhone 14 Pro
* [ ] iPad

**OS Testing**:

* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17

**Theme Testing**:

* [ ] Light theme
* [ ] Dark theme

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
  • Loading branch information
loremattei authored Feb 7, 2025
1 parent d8148cb commit 59338d2
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .maestro/shared/sync_recover_data.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ appId: com.duckduckgo.mobile.ios
- pressKey: Enter
- assertVisible: Get Started
- tapOn: Get Started
- runFlow:
when:
visible: Allows you to upload photographs and videos
commands:
- tapOn: "Allow"
- tapOn: Enter Text Code Manually
- tapOn: Paste
- assertVisible: Save Recovery Code
Expand Down

0 comments on commit 59338d2

Please sign in to comment.