Passwords: Update save pixel with backfilled value #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
amddg44
approved these changes
Jan 31, 2025
graeme
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 31, 2025
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1208273769335188/1209241071149720/f iOS PR: duckduckgo/iOS#3903 macOS PR: duckduckgo/macos-browser#3807 What kind of version bump will this require?: Major **Optional**: Tech Design URL: CC: **Description**: We're appending the backfilled parameter to the _update_ pixels, but not the _save_ pixels. So, for example, the case we're fixing for deviantart is not being captured if you're coming in fresh. Meaning, if you don't have credentials saved, we do backfill, but the pixel doesn't have backfilled=true, so we can't count it. I think at some point we started discussing only about the _update_ pixel and that was misinterpreted as don't change anything for _save_, but that was not the intention. The goal is to update the pixel firing logic both on macOS and iOS to match the above requirements **Steps to test this PR**: On both platforms... 1. Go to https://www.deviantart.com/users/login 2. Type in a username and hit Next 3. Type in a password and hit submit 4. You will see the Save password prompt with username and password 5. Check that you see `backfilled=true` in the save pixel on presentation, confirmation and dismissal 6. Save the password 7. Repeat steps 1 & 2 8. Type in a new password 9. You will see the Update password prompt with username and password 10. Check that you see `backfilled=true` in the update pixel on presentation, confirmation and dismissal <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1208273769335188/1209241071149720/f
Tech Design URL:
CC:
Description:
We're appending the backfilled parameter to the update pixels, but not the save pixels. So, for example, the case we're fixing for deviantart is not being captured if you're coming in fresh. Meaning, if you don't have credentials saved, we do backfill, but the pixel doesn't have backfilled=true, so we can't count it.
I think at some point we started discussing only about the update pixel and that was misinterpreted as don't change anything for save, but that was not the intention.
The goal is to update the pixel firing logic both on macOS and iOS to match the above requirements
Steps to test this PR:
backfilled=truein the save pixel on presentation, confirmation and dismissalbackfilled=truein the update pixel on presentation, confirmation and dismissalDefinition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template