Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwords: Update save pixel with backfilled value #1209

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Jan 31, 2025

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1208273769335188/1209241071149720/f
iOS PR: duckduckgo/iOS#3903
macOS PR: duckduckgo/macos-browser#3807
What kind of version bump will this require?: Major

Optional:

Tech Design URL:
CC:

Description:

We're appending the backfilled parameter to the update pixels, but not the save pixels. So, for example, the case we're fixing for deviantart is not being captured if you're coming in fresh. Meaning, if you don't have credentials saved, we do backfill, but the pixel doesn't have backfilled=true, so we can't count it.

I think at some point we started discussing only about the update pixel and that was misinterpreted as don't change anything for save, but that was not the intention.

The goal is to update the pixel firing logic both on macOS and iOS to match the above requirements

Steps to test this PR:

On both platforms...

  1. Go to https://www.deviantart.com/users/login
  2. Type in a username and hit Next
  3. Type in a password and hit submit
  4. You will see the Save password prompt with username and password
  5. Check that you see backfilled=true in the save pixel on presentation, confirmation and dismissal
  6. Save the password
  7. Repeat steps 1 & 2
  8. Type in a new password
  9. You will see the Update password prompt with username and password
  10. Check that you see backfilled=true in the update pixel on presentation, confirmation and dismissal

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme self-assigned this Jan 31, 2025
@graeme graeme requested a review from amddg44 January 31, 2025 10:18
@graeme graeme marked this pull request as ready for review January 31, 2025 10:18
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@graeme graeme merged commit 5b274fa into main Jan 31, 2025
7 checks passed
@graeme graeme deleted the graeme/fix-backfill-pixels branch January 31, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants