Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place open tab suggestions before history and bookmark suggestions #3800

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Place open tab suggestions before history and bookmark suggestions #3800

merged 4 commits into from
Jan 17, 2025

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1209138127674910/f
BSK PR: duckduckgo/BrowserServicesKit#1158

Description:

  • Fixes Open Tab suggestions ranking to prevail over history records and bookmarks

Steps to test this PR:

  1. create multiple bookmarks containing "duck" word
  2. open couple of tabs containing "duck" word but not contained in the bookmarks
  3. open a new tab, enter "duck", validate the open tabs are suggested

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@mallexxx mallexxx requested a review from brindy January 14, 2025 08:28
@mallexxx mallexxx mentioned this pull request Jan 14, 2025
Merged
1 task
brindy
brindy approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mallexxx mallexxx mentioned this pull request Jan 17, 2025
Merged
6 tasks
mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jan 17, 2025
@mallexxx
Place open tab suggestions before history and bookmark suggestions (#…
b3a8ea5 
…1158)

Task/Issue URL: https://app.asana.com/0/0/1209138127674910/f
iOS PR: duckduckgo/iOS#3800
macOS PR: duckduckgo/macos-browser#3660
@mallexxx mallexxx merged commit 7a3b779 into main Jan 17, 2025
13 checks passed
@mallexxx mallexxx deleted the alex/open-tab-ranking branch January 17, 2025 11:34
mallexxx added a commit to duckduckgo/macos-browser that referenced this pull request Jan 17, 2025
@mallexxx
Place open tab suggestions before history and bookmark suggestions (#…
757a2b7 
…3728)

Task/Issue URL: https://app.asana.com/0/0/1209138127674910/f
BSK PR: duckduckgo/BrowserServicesKit#1158
iOS PR: duckduckgo/iOS#3800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
includes-BSK-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @brindy