Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place open tab suggestions before history and bookmark suggestions #1158

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jan 14, 2025

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1209138127674910/f
iOS PR: duckduckgo/iOS#3800
macOS PR: duckduckgo/macos-browser#3660
What kind of version bump will this require?: Patch

Description:

  • Fix suggestions ranking to prefer Open Tabs over matching history records or bookmarks

Steps to test this PR:
1.
1.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mallexxx mallexxx merged commit b3a8ea5 into main Jan 17, 2025
9 checks passed
@mallexxx mallexxx deleted the alex/open-tab-ranking branch January 17, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants