Autofill engagement KPIs for pixel reporting (BSK update) #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d management screen
github-actions
bot
added
the
bot: not in app board
6 tasks
amddg44
removed
the
bot: not in app board
aataraxiaa
approved these changes
May 23, 2024
…pis-to-bsk # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 23, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1207357107981852/f iOS PR: duckduckgo/iOS#2885 macOS PR: duckduckgo/macos-browser#2806 What kind of version bump will this require?: Minor Description: Autofill engagement KPIs for pixel reporting
…pis-to-bsk # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
May 24, 2024
# By Christopher Brind (2) and others # Via GitHub * main: Autofill engagement KPIs for pixel reporting (BSK update) (#2885) keep strong reference to omnibar while we use it and add a ui test (#2884) Bump BSK (#2887) Recently visited sites UI update and rollout (#2838) Update Sync tests (#2837) Subscription refactoring (#2842) Update autoconsent to v10.8.0 (#2874) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/RemoteMessaging.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207357107981852/f
Tech Design URL:
CC:
Description:
Update to use BSK for Autofill engagement KPIs for pixel reporting
Steps to test this PR:
Disable Sync (if enabled). Reset Autofill data via the
Autofill Settingsdebug screen (this deletes all logins & reset the AutofillPixelReport userDefaults). Also reset the install date to 0Use
autofillas a filter for XCode console logsGo to https://fill.dev/form/login-simple, enter credentials and save when prompted
Confirm pixel
m.autofill.onboardeduseris fired (and that the messageAutofill save event firedlogs)Go back to https://fill.dev/form/login-simple and fill using the saved credentials
Confirm the message
Autofill fill event firedis loggedPerform a search
Confirm these 2 pixels are fired:
m.autofill.activeuser,m.autofill.logins.stacked ["count_bucket": "few"]Visit https://fill.dev/form/registration-email (sign into email if not already)
Select primary duck address
Confirm the message
Autofill fill event firedis loggedSelect private duck address
Confirm both
Autofill fill event firedandAutofill save event firedmessages are loggedChoose a generated password
Confirm just
Autofill fill event firedis logged (since the login is already autosaved due to choosing a private duck address)Click
Registerand then come back to the registration form screenThis time choose a generated password first and confirm both
Autofill fill event firedandAutofill save event firedmessages are loggedGo to the Passwords screen and manually create a new entry
Confirm the message
Autofill save event firedis logged"Reset Autofill Data" via Debug Autofill screen
Run up a macOS build and ensure you have at least 10 logins saved (can use this csv file if needed)
Sync with the iOS build
Confirm pixel
m.autofill.onboardeduseris fired (and that the messageAutofill save event firedlogs)Perform a search in browser
Confirm the pixel
m.autofill.enableduseris firedInternal references:
Software Engineering Expectations
Technical Design Template