Autofill engagement KPIs for pixel reporting #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…togenerated credentials
amddg44
changed the title
amddg44
commented
May 22, 2024
|
|
||
| @objc | ||
| private func didReceiveFillEvent() { | ||
| os_log(.debug, "Autofill fill event fired") |
There was a problem hiding this comment.
I put this temporary log in to make testing easier; I'll be removing before merging
amddg44
commented
May 22, 2024
|
|
||
| @objc | ||
| private func didReceiveSaveEvent() { | ||
| os_log(.debug, "Autofill save event fired") |
There was a problem hiding this comment.
Same as comment above
aataraxiaa
approved these changes
May 23, 2024
quanganhdo
added a commit
that referenced
this pull request
May 23, 2024
This reverts commit e1e4364.
quanganhdo
added a commit
that referenced
this pull request
May 23, 2024
This reverts commit 0463f58.
samsymons
added a commit
that referenced
this pull request
May 24, 2024
samsymons
added a commit
that referenced
this pull request
Jun 1, 2024
* main: Replace unowned reference with weak one (#832) Removes VPN waitlist and beta code (#801) Add `survey` action and Privacy Pro attributes (#826) Autofill engagement KPIs for pixel reporting (#830) Bump C-S-S to 5.17.0 (#828) ensure bookmarks can be shown in top hits (#818) Subscription refactoring (#815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1207357107981852/f
iOS PR: duckduckgo/iOS#2885
macOS PR: duckduckgo/macos-browser#2806
What kind of version bump will this require?: Minor
Description:
Autofill engagement KPIs for pixel reporting
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template