Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the GRDB dependency to HTTPS #1

Merged
merged 3 commits into from
Apr 25, 2021
Merged

Migrate the GRDB dependency to HTTPS #1

merged 3 commits into from
Apr 25, 2021

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Apr 25, 2021 •
edited
Loading

cc @brindy

This PR includes three changes:

  1. The GRDB dependency has moved to HTTPS, to circumvent Bitrise SSH authentication issues
  2. A CODEOWNERS file has been added
  3. A pull request template has been added

Steps to test this PR:

  1. Check out the branch locally and make sure that swift build clones GRDB successfully and is able to build

@samsymons samsymons requested a review from brindy April 25, 2021 19:46
brindy
brindy approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran swift test - LGTM, thanks @samsymons !

@samsymons samsymons merged commit 80f324d into develop Apr 25, 2021
@samsymons samsymons deleted the feature/sam/update-grdb-dependency branch April 25, 2021 20:20
federicocappelli added a commit that referenced this pull request May 9, 2024
@federicocappelli
iOS compatibility #1
6f3651c
federicocappelli added a commit that referenced this pull request Aug 20, 2024
@federicocappelli
Logging refactoring #1 Subscription and Content Blocking (#940)
2efee14 
Task/Issue URL:
https://app.asana.com/0/1205842942115003/1206750146033742/f
iOS PR: duckduckgo/iOS#3219
macOS PR: duckduckgo/macos-browser#3091
What kind of version bump will this require?: **Major**, breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @brindy