Skip to content

Commit

Permalink
Migrate the GRDB dependency to HTTPS (#1)
Browse files Browse the repository at this point in the history
* Swap to HTTPS for GRDB.

* Add codeowners and PR template files.

* Update the PR template.
  • Loading branch information
samsymons authored Apr 25, 2021
1 parent 393d4b8 commit 80f324d
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# These people are listed as being the code owners for this project. As such, they will be automatically added as a reviewer when a PR is created.
# For more details on how this is configured, see https://help.github.com/articles/about-code-owners/

* @brindy @bwaresiak @mallexxx @THISISDINOSAUR @tomasstrba @samsymons
33 changes: 33 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!--
Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required.
-->

Task/Issue URL:
Tech Design URL:
CC:

**Description**:


**Steps to test this PR**:
1.
1.

<!--
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
-->

**OS Testing**:

* [ ] iOS 13
* [ ] iOS 14

* [ ] macOS 10.15
* [ ] macOS 11

---
###### Internal references:
[Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
2 changes: 1 addition & 1 deletion Package.resolved
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"pins": [
{
"package": "GRDB",
"repositoryURL": "git@github.com:duckduckgo/GRDB.swift.git",
"repositoryURL": "https://github.com/duckduckgo/GRDB.swift.git",
"state": {
"branch": "SQLCipher",
"revision": "e5714d4b6ee1651d2271b04ae85aaf5a327fe70a",
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ let package = Package(
.library(name: "SecureVault", targets: ["SecureVault"]),
],
dependencies: [
.package(name: "GRDB", url: "git@github.com:duckduckgo/GRDB.swift.git", .branch("SQLCipher")),
.package(name: "GRDB", url: "https://github.com/duckduckgo/GRDB.swift.git", .branch("SQLCipher")),
],
targets: [
.target(
Expand Down

0 comments on commit 80f324d

Please sign in to comment.