Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync to latest #2

Merged
merged 7 commits into from
Feb 16, 2021
Merged

sync to latest #2

merged 7 commits into from
Feb 16, 2021

Conversation

dubious90
Copy link
Owner

No description provided.

Otto van der Schaaf and others added 7 commits February 5, 2021 18:49
I think the root cause is that the alpine-glibc image updates,
and through that dependency requirements can no longer be met.

This PR
- pins the alpine image at the latest version
- changes the dependency versions so they work again

Note: the `>=` for python was changed to `=` as otherwise we'd
write a file to disk mentioning the version, this seemed contra
intent.

There's a complaint [1] emitted during the image build, so we need to
see if everything is OK when CI finishes.

[1] /usr/glibc-compat/sbin/ldconfig: /usr/glibc-compat/lib/ld-linux-x86-64.so.2 is not a symbolic link

Signed-off-by: Otto van der Schaaf <[email protected]>
* Update Envoy to cfe0391 (Feb 5th 2021).

- synchronizing `.bazelrc` from Envoy repository.
- the API of `getJsonStringFromMessage` changed, it now returns `ProtobufUtil::StatusOr` instead of `std::string`. Switching our code over to `getJsonStringFromMessageOrDie` which continues to return `std::string`.
- Increased the `no_output_timeout` parameter to 30m for test_gcc which was timing out.

Signed-off-by: Jakub Sobon <[email protected]>
Step by step guide on how to perform the update.
Marking our local changes in .bazelrc with #unique. To make it easier to spot them.
Reformatting MAINTAINERS.md, adding line breaks at 80 char where appropriate.

Signed-off-by: Jakub Sobon <[email protected]>
Being able to serialize and deserialize statistics serves several goals:
- Allow over-the-wire transportation in horizontally scaled setups.
- Facilitate storage of high res data.
- Could be used as a means to decouple our workers from the main thread,
  by avoiding reliance on a shared process namespace to merge statistics.
  (not a goal right now)

This adds an abstraction to Statistic, implements it for HdrHistogram, and
adds some tests.

Part of horizontal scaling effort, split out from:
Split out from https://github.com/oschaaf/nighthawk/tree/horizontal-scaling

Signed-off-by: Otto van der Schaaf <[email protected]>
An adaptive load command line executable that drives a Nighthawk Service with a series of benchmarks, varying the RPS or another input variable dynamically.

`bazel build -c opt :nighthawk`

`bazel-bin/nighthawk_adaptive_load_client`

- `--spec-file` _pathname_
  - Pathname of an `AdaptiveLoadSessionSpec` textproto defining the session
  - Required
  - Example:`test/adaptive_load/test_data/valid_session_spec.textproto`
- `--output-file` _pathname_ 
  - Pathname to write the `AdaptiveLoadSessionOutput` textproto session output
  - Required
- `--nighthawk-service-address` _host:port_ 
  - Address of the Nighthawk Service to be driven by the adaptive load controller over gRPC
  - Default `localhost:8443`
- `--use-tls`
  - Use TLS for the gRPC connection when sending commands to the Nighthawk Service
  - Default false (insecure connection)

Note that to run an adaptive load session, you must also have a Nighthawk Service running, e.g.:
`bazel-bin/nighthawk_service &`  (to run at localhost:8443)

Part of #416.

Signed-off-by: eric846 <[email protected]>
- don't set up a drain callback when there are no active connections
- set up a timer that will cap the amount of time we wait for the pool
  to drain.
- disable latency measurement when commencing the drain procedure, as
  by that time we are no longer interested in it, and in particular
  don't want to hear about any warnings issued by the Statistic
  implementation about recorded values being too large. 

Fixes #627

Signed-off-by: Otto van der Schaaf <[email protected]>
Fixes #629

Signed-off-by: Otto van der Schaaf <[email protected]>
@dubious90 dubious90 merged commit e01ff2b into dubious90:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants