Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address current clang-tidy complaints #629

Closed
oschaaf opened this issue Feb 14, 2021 · 0 comments · Fixed by #630
Closed

Address current clang-tidy complaints #629

oschaaf opened this issue Feb 14, 2021 · 0 comments · Fixed by #630
Labels
tech-debt

Comments

@oschaaf
Copy link
Member

oschaaf commented Feb 14, 2021

A while ago clang-tidy started failing in CI [1] and the intermediate solution was to disable the task
so it would not block merges of incoming pull requests. Running clang_tidy locally it looks like we've
been building up some tech debt with respect to cleanly passing the clang_tidy check.
Filing this issue as a hook for an upcoming PR to address that.

[1] #546
oschaaf pushed a commit to oschaaf/nighthawk that referenced this issue Feb 14, 2021
clang-tidy: address complaints
3df8c4c 
Fixes envoyproxy#629

Signed-off-by: Otto van der Schaaf <[email protected]>
oschaaf pushed a commit to oschaaf/nighthawk that referenced this issue Feb 14, 2021
clang-tidy: address complaints
c221368 
Fixes envoyproxy#629

Signed-off-by: Otto van der Schaaf <[email protected]>
@oschaaf oschaaf mentioned this issue Feb 14, 2021
Merged
mum4k pushed a commit that referenced this issue Feb 15, 2021
clang-tidy: address complaints (#630)
c89cf75 
Fixes #629

Signed-off-by: Otto van der Schaaf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clang-tidy: address complaints oschaaf/nighthawk
1 participant
@oschaaf