xSslSettings: Resolve Casing in Name #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change there was inconsistency in the way files referring to this resource were named. The proper naming convention is `*xSslSettings*` rather than `*xSSLSettings*`. - Fixes dsccommunity#536 - [x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable). - [x] Resource documentation added/updated in README.md. - [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help. - [ ] Comment-based help added/updated. - [ ] Localization strings added/updated in all localization files as appropriate. - [x] Examples appropriately added/updated. - [x] Unit tests added/updated. See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md). - [x] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md). - [x] New/changed code adheres to [DSC Resource Style Guidelines](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](https://github.com/PowerShell/DscResources/blob/master/BestPractices.md).
Codecov Report
@@ Coverage Diff @@
## dev #537 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 17 17
Lines 2766 2766
=======================================
Hits 2537 2537
Misses 229 229
Continue to review full report at Codecov.
|
9 tasks
johlju
approved these changes
Oct 20, 2019
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
gstorme
pushed a commit
to gstorme/xWebAdministration
that referenced
this pull request
Feb 14, 2020
- Changes to xSslSettings
- Updated casing of `xSslSettings` in all file names, folder names, schema,
and documentation (issue dsccommunity#536).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change there was inconsistency in the way files referring
to this resource were named. The proper naming convention is
*xSslSettings*rather than*xSSLSettings*.Fixes xSslSettings: Resolve casing in name #536
Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
Resource documentation added/updated in README.md.
Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
Comment-based help added/updated.
Localization strings added/updated in all localization files as appropriate.
Examples appropriately added/updated.
Unit tests added/updated. See DSC Resource Testing Guidelines.
Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
New/changed code adheres to DSC Resource Style Guidelines and Best Practices.
This change is