Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSslSettings: Resolve casing in name #536

Closed
johlju opened this issue Oct 15, 2019 · 5 comments · Fixed by #537
Closed

xSslSettings: Resolve casing in name #536

johlju opened this issue Oct 15, 2019 · 5 comments · Fixed by #537
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Oct 15, 2019

There are files and folders that are named xSSLSettings instead of xSslSettings(lower-case 'sl'). Also code referencing xSSLSettings should be changed to xSslSettings.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ help wanted The issue is up for grabs for anyone in the community. labels Oct 15, 2019
RandomNoun7 added a commit to RandomNoun7/xWebAdministration that referenced this issue Oct 16, 2019
@RandomNoun7
(GHIssue dsccommunity#536) Resolve xSslSettings Name Case
cb1026a 
Fix case for these files.
RandomNoun7 added a commit to RandomNoun7/xWebAdministration that referenced this issue Oct 16, 2019
@RandomNoun7
xSslSettings: Resolve Casing in Name
8d1c843 
Prior to this change there was inconsistency in the way files referring
to this resource were named. The proper naming convention is
`*xSslSettings*` rather than `*xSSLSettings*`.

- Fixes dsccommunity#536

- [x] Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
      Entry should say what was changed and how that affects users (if applicable), and
      reference the issue being resolved (if applicable).
- [x] Resource documentation added/updated in README.md.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof
      and comment-based help.
- [ ] Comment-based help added/updated.
- [ ] Localization strings added/updated in all localization files as appropriate.
- [x] Examples appropriately added/updated.
- [x] Unit tests added/updated. See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md).
- [x] New/changed code adheres to [DSC Resource Style Guidelines](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](https://github.com/PowerShell/DscResources/blob/master/BestPractices.md).
@RandomNoun7 RandomNoun7 mentioned this issue Oct 16, 2019
Merged
9 tasks
@RandomNoun7
Copy link
Contributor

@johlju It seems likely the person who did #504 may have thought they fixed the file and folder names previously. Unfortunately, fixing the case of folders and files like this on a Windows system is very difficult. The only practical way to do it is as I did, which is the clone the repository down to a Linux system that has a case sensitive file system, and use git mv -f to get the file moves done in a way that git will retain in a commit.

I hope this is what you're looking for here.

@johlju
Copy link
Member Author

johlju commented Oct 16, 2019 •
edited
Loading

Is is possible to do it on Windows too by renaming (using git mv) the folder and files to something else and then back to the correct name.

I missed the problem in the files and folders when reviewing the previous PR. But I think that PR solved all the code changes. 😊

@johlju
Copy link
Member Author

johlju commented Oct 16, 2019

Thank you for the PR 😄

@RandomNoun7
Copy link
Contributor

It should be possible in theory, but it doesn't quite work. Git always gets confused about which files are being moved around. Maybe if you did the moves in a really granular way committing each move as you did them you could get it done. But it's much easier to just spin up an ubunutu container and move them directly :)

@johlju
Copy link
Member Author

johlju commented Oct 16, 2019

Agree it is faster in Linux. So rarely I done it, just a file here and there, so I did the granular approach of renaming. :)

johlju pushed a commit that referenced this issue Oct 20, 2019
@RandomNoun7 @johlju
xSslSettings: Resolve Casing in Name (#537)
31fb926 
- Changes to xSslSettings
  - Updated casing of `xSslSettings` in all file names, folder names, schema,
    and documentation (issue #536).
gstorme pushed a commit to gstorme/xWebAdministration that referenced this issue Feb 14, 2020
@RandomNoun7
xSslSettings: Resolve Casing in Name (dsccommunity#537)
5f5496a 
- Changes to xSslSettings
  - Updated casing of `xSslSettings` in all file names, folder names, schema,
    and documentation (issue dsccommunity#536).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub hacktoberfest See https://hacktoberfest.digitalocean.com/ help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xSslSettings: Resolve Casing in Name RandomNoun7/xWebAdministration
2 participants
@johlju @RandomNoun7