Lock concurrent-ruby gem to fix CI
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address compatibility issues with Rails 7.0, this commit locks `concurrent-ruby` gem to version 1.3.4. This change is necessary to prevent an uninitialized constant error related to `ActiveSupport::LoggerThreadSafeLevel::Logger`, as documented in issue rails/rails#54260. By specifying this version, we ensure that our CI integration specs pass consistently, providing a stable development and testing environment. This measure will remain in place until the integration tests upgrade to Rails 7.1, which involves significant changes that require careful consideration and testing.
tagliala
force-pushed
the
chore/fix-integration-ci
branch
from
4038a54 to
69c4095
Compare
Merged
|
Thank you very much for submitting this! |
drwl
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address compatibility issues with Rails 7.0, this commit locks
concurrent-rubygem to version 1.3.4.This change is necessary to prevent an uninitialized constant error related to
ActiveSupport::LoggerThreadSafeLevel::Logger, as documented in issue rails/rails#54260.By specifying this version, we ensure that our CI integration specs pass consistently, providing a stable development and testing environment.
This measure will remain in place until the integration tests upgrade to Rails 7.1, which involves significant changes that require careful consideration and testing.