Fix typos #165
Merged
Fix typos #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwl
requested changes
Jan 22, 2025
tagliala
force-pushed
the
chore/fix-typos
branch
from
2c63ba0 to
5ec7b33
Compare
tagliala
force-pushed
the
chore/fix-typos
branch
from
5ec7b33 to
b17a4eb
Compare
|
Comment addressed and rebased. Failures depend on a change related to concurrent ruby which is not requiring logger anymore. This should be fixed in Rails >= 7.1. Rails 7.0 is in EOL and will not be fixed |
drwl
approved these changes
Jan 23, 2025
Thank you! It seems like I'll have to do some work with the testing harness to fix CI. |
|
Welcome
In the meanwhile, you can merge #180 to have a green build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes to production code
Found with
codespell