fix: redundant ACL computation #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamegraph.com reportCreated by Flamegraph.com Github Action |
trungnotchung
requested review from
JanLewDev,
winprn,
hoangquocvietuet and
magnified103
as code owners
winprn
approved these changes
Feb 19, 2025
sfroment
force-pushed
the
fix/recompute-acl
branch
2 times, most recently
from
cbc4951 to
069c521
Compare
Signed-off-by: Sacha Froment <[email protected]>
sfroment
force-pushed
the
fix/recompute-acl
branch
from
069c521 to
f64a11e
Compare
JanLewDev
pushed a commit
that referenced
this pull request
Feb 19, 2025
Signed-off-by: Sacha Froment <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
callFnandmergefunctions that always computedrpandaclon top of both functions. So that we can utilize these pre-compute values instead of re-computing them many times._initializeFinalityStatethat can accept an acl as a parameter instead of recompute it._computeObjectACLto return an ACL instead of DRP.Related Issues and PRs
_initializeFinalityState#463Added/updated tests?
Additional Info
add instructions or screenshots on what you might think is relevant or instructions on how to manually test it
[optional] Do we need to perform any post-deployment tasks?