[FEATURE] - Avoid Redundant ACL Computation in _initializeFinalityState

[trungnotchung]

Problem Description

The method _initializeFinalityState(hash: Hash) currently recomputes the ACL even though the ACL might have already been computed and stored in the codebase.

// initialize the attestation store for the given vertex hash
	private _initializeFinalityState(hash: Hash) {
		if (!this.acl || !this.originalObjectACL) {
			throw new Error("ObjectACL is undefined");
		}
		const fetchedState = this.aclStates.get(hash);
		if (fetchedState !== undefined) {
			const state = cloneDeep(fetchedState);
			const acl = cloneDeep(this.originalObjectACL);

			for (const entry of state.state) {
				acl[entry.key] = entry.value;
			}
			// signer set equals writer set
			this.finalityStore.initializeState(hash, acl.query_getFinalitySigners());
		}
	}

cloneDeep operations are costly, and this function runs every time _initializeFinalityState is called when a new vertex is added to the hash graph. This results in unnecessary recomputation and inefficiency.

Proposed Solution

Instead of recomputing ACL every time, modify _initializeFinalityState to directly accept a precomputed acl

Implementation PR

No response

Reference Issues

No response

Unresolved questions

No response

Additional Information

No response