Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong initial bitset size #349

Merged
merged 4 commits into from
Jan 13, 2025
Merged

fix: wrong initial bitset size #349

merged 4 commits into from
Jan 13, 2025

Conversation

magnified103
Copy link
Contributor

@magnified103 magnified103 commented Jan 13, 2025 •
edited
Loading

The buffer sizes in the bitsets were calculated incorrectly, causing memory consumption to be 32 times worse.

This PR fixes the issue and removes unused functions.

Memory consumption changes for obj.hashGraph.reachablePredecessors during linearization:

  • 5k vertices: 349.9 MB -> 12.9 MB
  • 2k vertices: 33.7 MB -> 1.5 MB

d-roak
d-roak approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit ff657ad into main Jan 13, 2025
12 checks passed
@magnified103 magnified103 mentioned this pull request Jan 13, 2025
Merged
@magnified103 magnified103 deleted the fix/bitset branch January 13, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak approved these changes

@JanLewDev JanLewDev Awaiting requested review from JanLewDev JanLewDev is a code owner

@trungnotchung trungnotchung Awaiting requested review from trungnotchung trungnotchung is a code owner

@winprn winprn Awaiting requested review from winprn winprn is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet

@anhnd350309 anhnd350309 Awaiting requested review from anhnd350309 anhnd350309 is a code owner

@sfroment sfroment Awaiting requested review from sfroment sfroment is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnified103 @d-roak