-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: finality with bls signature approach #314
Conversation
07dd438
to
760026e
Compare
fixed in 6934d13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR introduces:
DRPCredentialStore
(node/store/index.ts) holds the private keys and public keys for vertex signing and voting.DRPCredentialConfig
contains the initial seed for key generation.DRPPublicCredential
contains the public keys, base64-encoded.FinalityState
andFinalityStore
(object/finality) hold the finality and voting status for hashgraph vertices.Attestation
object holds a vertex hash and a signature representing a single vote.AggregatedAttestation
contains a vertex hash, an aggregate of multiple signatures and a bitset indicating who voted.ATTESTATION_UPDATE
broadcast message: broadcast the attestations generated by a node upon receiving an UPDATE message.