Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of standard ISO-8859-1 encoding #436

Merged
merged 3 commits into from
Sep 15, 2019
Merged

Added support of standard ISO-8859-1 encoding #436

merged 3 commits into from
Sep 15, 2019

Conversation

jonasvoelcker
Copy link
Contributor

@jonasvoelcker jonasvoelcker commented Sep 13, 2019

Fixes #437

Hey guys, we are using your framework in our company and face a situation where the encoding of our images can not be determined.

According to this page, the "1B 2E 41" which can be found in our "CodedCharacterSet" belongs to the ISO-8859-1 encoding.

http://nozer0.github.io/en/technology/system/character-encoding/

Hey guys, we are using your framework in our company and face a situation where the encoding of our images can not be determined.

According to this page, the "1B 2E 41" which can be found in our "CodedCharacterSet" belongs to the ISO-8859-1 encoding.

http://nozer0.github.io/en/technology/system/character-encoding/
Hey guys, we are using your framework in our company and face a situation where the encoding of our images can not be determined.

According to this page, the "1B 2E 41" which can be found in our "CodedCharacterSet" belongs to the ISO-8859-1 encoding.

http://nozer0.github.io/en/technology/system/character-encoding/
@drewnoakes
Copy link
Owner

This looks great. Could you add that URL to the Javadoc of the method you've modified please? It's a great resource and will be useful in future. Encoding issues pop up regularly.

Copy link
Owner

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drewnoakes drewnoakes merged commit ef906fb into drewnoakes:master Sep 15, 2019
@jonasvoelcker jonasvoelcker deleted the patch-1 branch September 15, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing support of standard ISO-8859-1 encoding
2 participants