Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support of standard ISO-8859-1 encoding #437

Closed
jonasvoelcker opened this issue Sep 13, 2019 · 7 comments · Fixed by #436
Closed

Missing support of standard ISO-8859-1 encoding #437

jonasvoelcker opened this issue Sep 13, 2019 · 7 comments · Fixed by #436

Comments

@jonasvoelcker
Copy link
Contributor

Hey guys, we are using your framework in our company and face a situation where the encoding of our images can not be determined.

According to this page, the "1B 2E 41" which can be found in our "CodedCharacterSet" belongs to the ISO-8859-1 encoding.

http://nozer0.github.io/en/technology/system/character-encoding/

I've added a pull request which should fix this special case and hopefully solve our issue ;)

We would like to go into production before the end of this year, so hopefully you can make it a hotfix or release before? ;)

Best regards
Jonas

@drewnoakes
Copy link
Owner

Thanks for the great bug report and PR. I'll take a look at it shortly and get a release out.

Could you provide an image that uses this encoding? It would help debugging and prevent regressions in future.

@jonasvoelcker
Copy link
Contributor Author

That was fast, thanks for the rapid response :)

Unfortunately I cannot provide a picture of the company and actually I don't know how to produce any image with the same issue.

Regardless of the missing picture our try to change the "charsetName" within the IptcReader in debugging mode to "ISO-8859-1" solved the misinterpretation of the Strings "Köln" and "fühlt", which were previously interpreted as "K�ln" and "f�hlt".

The link has been added to the javadoc as you requested ;)

@drewnoakes
Copy link
Owner

Thanks again Jonas. I'll get a release out soon.

@jonasvoelcker
Copy link
Contributor Author

That's great, thanks for your effort :)

@jonasvoelcker
Copy link
Contributor Author

Helllo Drew,

last time we wrote, you announced a release being done soon. Now it is over a month. ;)

Best regards

@drewnoakes
Copy link
Owner

Thanks for the reminder. I need to set up my other machines to do release. It's more complex to publish to Maven than it is for NuGet. I'm away from my main workstation until the weekend, so will look into this then.

@jonasvoelcker
Copy link
Contributor Author

Hello again,

it would be really lovely, if you would finally release this feature, even if it is just a hotfix.

The last month we didn't get any further errors so we thought, our images might have been fixed, but now I have run into the same error again.

We do need this at least in January, otherwise it will crash our schedule :/

Best Regards
Jonas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants