Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(zh-CN): refactor machine translation #783

Merged
merged 8 commits into from
Dec 3, 2021
Merged

docs(zh-CN): refactor machine translation #783

merged 8 commits into from
Dec 3, 2021

Conversation

zzy987
Copy link
Contributor

@zzy987 zzy987 commented Nov 4, 2021 •
edited
Loading

Description

Remove machine translations.

Related Issue

#781

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zzy987 zzy987 requested a review from a team as a code owner November 4, 2021 10:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021 •
edited
Loading

Codecov Report

Merging #783 (6fa65f9) into main (1247514) will increase coverage by 0.23%.
The diff coverage is n/a.

❗ Current head 6fa65f9 differs from pull request most recent head 19e128e. Consider uploading reports for the commit 19e128e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
+ Coverage   41.19%   41.43%   +0.23%     
==========================================
  Files         102      103       +1     
  Lines        8066     8047      -19     
==========================================
+ Hits         3323     3334      +11     
+ Misses       4332     4303      -29     
+ Partials      411      410       -1
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 41.43% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 46.06% <0.00%> (-0.61%) ⬇️
cdn/rpcserver/rpcserver.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_file.go 52.02% <0.00%> (ø)
client/daemon/rpcserver/rpcserver.go 34.28% <0.00%> (ø)
client/daemon/peer/peertask_file_callback.go 56.19% <0.00%> (ø)
client/daemon/peer/peertask_stream_callback.go 64.07% <0.00%> (ø)
internal/dfutils/dfutils.go 100.00% <0.00%> (ø)
client/daemon/daemon.go 5.72% <0.00%> (+0.05%) ⬆️
client/daemon/peer/piece_manager.go 68.26% <0.00%> (+0.11%) ⬆️
client/daemon/peer/peertask_stream.go 56.26% <0.00%> (+0.30%) ⬆️
... and 1 more

244372610
244372610 previously approved these changes Nov 25, 2021
View reviewed changes
yxxhero
yxxhero reviewed Nov 25, 2021
View reviewed changes
docs/zh-CN/cli-reference/README.md Outdated Show resolved Hide resolved
docs/zh-CN/cli-reference/README.md Show resolved Hide resolved
docs/zh-CN/cli-reference/dfget.md Outdated Show resolved Hide resolved
docs/zh-CN/cli-reference/dfget.md Show resolved Hide resolved
@yxxhero
Copy link
Member

yxxhero commented Nov 26, 2021

need rebase @zzy987

@yxxhero
Copy link
Member

yxxhero commented Dec 1, 2021

@zzy987 Please fix conflicts. Thanks very much.

jim3ma
jim3ma previously requested changes Dec 1, 2021
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update helm-charts

yxxhero
yxxhero previously approved these changes Dec 2, 2021
View reviewed changes
@yxxhero
Copy link
Member

yxxhero commented Dec 2, 2021

@zzy987 Please fix markdown lint issue. Thanks very much.

@zzy987
doc: markdown lint
320362d 
Signed-off-by: zzy987 <[email protected]>
zzy987 added 2 commits December 2, 2021 21:06
@zzy987
doc: markdown lint
6fa65f9 
Signed-off-by: zzy987 <[email protected]>
@zzy987
doc: markdown lint
19e128e 
Signed-off-by: zzy987 <[email protected]>
@zzy987 zzy987 requested a review from yxxhero December 2, 2021 13:13
@yxxhero
Copy link
Member

yxxhero commented Dec 2, 2021

@zzy987 Thanks very much agagin. Thank for your work.

yxxhero
yxxhero reviewed Dec 2, 2021
View reviewed changes
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gaius-qi
gaius-qi approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero
Copy link
Member

yxxhero commented Dec 3, 2021

@zzy987 you should mark the request changes to be resolved. So I can merged it.

@yxxhero yxxhero merged commit 25336d1 into dragonflyoss:main Dec 3, 2021
@zzy987 zzy987 deleted the docs/refactor-machine-translation branch December 6, 2021 11:47
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@zzy987 @gaius-qi
docs(zh-CN): refactor machine translation (#783)
01fe475 
* docs(zh-CN): remove README.md machine translation

Signed-off-by: zzy987 <[email protected]>

* docs: fixed some machine translation

Signed-off-by: zzy987 <[email protected]>

* fix: some translation

Signed-off-by: zzy987 <[email protected]>

* chore: update helm-charts

Signed-off-by: zzy987 <[email protected]>

* doc: markdown lint

Signed-off-by: zzy987 <[email protected]>

* doc: markdown lint

Signed-off-by: zzy987 <[email protected]>

* doc: markdown lint

Signed-off-by: zzy987 <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
@gaius-qi
feat: add health check for manager addr (dragonflyoss#783)
828b925 
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@yxxhero yxxhero yxxhero approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@ansinlee ansinlee Awaiting requested review from ansinlee ansinlee is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@jim3ma jim3ma Awaiting requested review from jim3ma

@244372610 244372610 Awaiting requested review from 244372610

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zzy987 @codecov-commenter @yxxhero @jim3ma @gaius-qi @244372610