Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement FindProbedHosts and add LoadRandomHosts to host manager #2519

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jul 5, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Jul 5, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Jul 5, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner July 5, 2023 06:36
@gaius-qi gaius-qi self-assigned this Jul 5, 2023
@gaius-qi gaius-qi force-pushed the feature/find-probed-host branch from e7ca2a6 to dd8d404 Compare July 5, 2023 06:44
@gaius-qi gaius-qi force-pushed the feature/find-probed-host branch from dd8d404 to 8f8abd0 Compare July 5, 2023 06:46
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2519 (da04663) into main (d74ef98) will increase coverage by 0.03%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
+ Coverage   51.91%   51.95%   +0.03%     
==========================================
  Files         154      154              
  Lines       20611    20654      +43     
==========================================
+ Hits        10701    10730      +29     
- Misses       9292     9305      +13     
- Partials      618      619       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.95% <89.74%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/host_manager_mock.go 40.38% <0.00%> (-7.35%) ⬇️
scheduler/resource/host_manager.go 86.44% <76.47%> (-4.04%) ⬇️
pkg/slices/slices.go 100.00% <100.00%> (ø)
scheduler/networktopology/network_topology.go 100.00% <100.00%> (+1.11%) ⬆️
scheduler/service/service_v1.go 80.72% <100.00%> (-0.12%) ⬇️
scheduler/service/service_v2.go 85.61% <100.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 1da3550 into main Jul 6, 2023
@gaius-qi gaius-qi deleted the feature/find-probed-host branch July 6, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants