Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit tests of FindProbedHosts and LoadRandomHosts in host manager #2520

Merged
merged 3 commits into from
Jul 5, 2023
Merged

test: add unit tests of FindProbedHosts and LoadRandomHosts in host manager #2520

merged 3 commits into from
Jul 5, 2023

Conversation

fcgxz2003
Copy link
Member

Add unit tests of FindProbedHosts and LoadRandomHosts in host manager.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@fcgxz2003
fix
440893c 
Signed-off-by: XZ <[email protected]>
@fcgxz2003 fcgxz2003 requested a review from a team as a code owner July 5, 2023 08:43
@fcgxz2003 fcgxz2003 requested review from jim3ma, yxxhero and bigerous and removed request for a team July 5, 2023 08:43
fcgxz2003 added 2 commits July 5, 2023 16:46
@fcgxz2003
fix
0c226c8 
Signed-off-by: XZ <[email protected]>
@fcgxz2003
fix
9b72906 
Signed-off-by: XZ <[email protected]>
gaius-qi
gaius-qi approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit da04663 into dragonflyoss:feature/find-probed-host Jul 5, 2023
@fcgxz2003 fcgxz2003 deleted the gaius-find-probed-host branch July 7, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@jim3ma jim3ma Awaiting requested review from jim3ma jim3ma was automatically assigned from dragonflyoss/dragonfly2-reviewers

@yxxhero yxxhero Awaiting requested review from yxxhero yxxhero was automatically assigned from dragonflyoss/dragonfly2-reviewers

@bigerous bigerous Awaiting requested review from bigerous bigerous was automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcgxz2003 @gaius-qi